cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

Add financial system

Open zpano opened this issue 1 year ago • 3 comments

Fixes #973

PR Checklist

  • [x] Tests
  • [ ] Documentation
  • [ ] Added entry to CHANGELOG.md
  • [ ] Tried the feature on a public network

zpano avatar Apr 24 '24 07:04 zpano

Hey @zpano, thanks for taking the time to contribute. Note that we expect the PR to contain a strong test suite before reviewing it, and documentation before merging it.

ericnordelo avatar Apr 24 '24 11:04 ericnordelo

@ericnordelo How can i write an documentation?

zpano avatar Apr 26 '24 02:04 zpano

Hey, @zpano! Thanks for opening the PR. Here are the basic guidelines for contributing: https://github.com/OpenZeppelin/cairo-contracts/blob/main/CONTRIBUTING.md

How can i write an documentation?

An example of in-code docs: https://github.com/OpenZeppelin/cairo-contracts/blob/main/src/token/erc20/erc20.cairo#L117-L124

And here's instructions for the docsite: https://github.com/OpenZeppelin/cairo-contracts/blob/main/CONTRIBUTING.md#documentation

Let us know if you have any questions

andrew-fleming avatar Apr 26 '24 17:04 andrew-fleming

Thank you for your contribution! From this point we're going to take over the implementation of Vesting Components, make the necessary changes and bring it to life

immrsd avatar Aug 20 '24 15:08 immrsd

Closing as we already merged VestingComponent in #1116

ericnordelo avatar Oct 15 '24 16:10 ericnordelo