nile icon indicating copy to clipboard operation
nile copied to clipboard

Refactor accounts.json and deployments.txt files

Open ericnordelo opened this issue 2 years ago • 2 comments

Currently, the project is creating these files when setting up accounts or deploying contracts: [network].accounts.json and [network].deployments.txt

Room for improvement:

  • Format inconsistency (json and txt).
  • Structure inconsistency.
  • Merging hex and integers (public_key as int, and address as hex).
  • Multiple files at the project's root directory (one account and one deployment for each network). Maybe having a folder for deployments would be helpful?
  • nile init creating an account.json file that is never used (not having the network)

ericnordelo avatar Sep 21 '22 12:09 ericnordelo

This issue can be extended to have a proper deployment system to be able to define and re-execute flows, but that is certainly bigger and can be implemented with plugins.

ericnordelo avatar Sep 21 '22 12:09 ericnordelo

big plus one to all those issues. i was convinced we had an issue tracking the multiple files, format, and structure problems but could not find it.

martriay avatar Sep 21 '22 21:09 martriay