Add support of the command MOVE

[PragmaTwice]

Refer to https://redis.io/commands/move/

[jihuayu]

Kvrocks don't have DB, we have namespace instead. So should we use namespace token in this command?

move key namespace_token

[PragmaTwice]

Kvrocks don't have DB, we have namespace instead. So should we use namespace token in this command?

move key namespace_token

Looks good to me. cc @git-hulk

[git-hulk]

Kvrocks don't have DB, we have namespace instead. So should we use namespace token in this command?

move key namespace_token

Looks good to me. cc @git-hulk

Good to me +1

[mapleFU]

proposal is ok to me

[kay011]

This command was implemented by @enjoy-binbin in #1723 but now it is a dummy command. Are we sure to change the actual operation of the command which is different from Redis?

[enjoy-binbin]

I think it’s better to keep the redis style MOVE key db.

If we specifially need such a feature, we should add a new command, or at least do it in a way that is compatible with redis style.

[jihuayu]

@enjoy-binbin Add a new command looks good to me.

I provide a compatible solution: When command args size is 3, MOVE key db , we treat it a dummy command. When command args size is 4, MOVE key ns_name ns_token ,we move it to new namespace.

[haanhvu]

@enjoy-binbin Add a new command looks good to me.

I provide a compatible solution: When command args size is 3, MOVE key db , we treat it a dummy command. When command args size is 4, MOVE key ns_name ns_token ,we move it to new namespace.

This has not been implemented right? I'll work on this.

[jihuayu]

@enjoy-binbin Add a new command looks good to me. I provide a compatible solution: When command args size is 3, MOVE key db , we treat it a dummy command. When command args size is 4, MOVE key ns_name ns_token ,we move it to new namespace.

This has not been implemented right? I'll work on this.

No. But let's check with @git-hulk @PragmaTwice to make sure this is the ok behavior.

[git-hulk]

I'm fine with @enjoy-binbin solution. BTW, we must forbid using this command if the cluster mode is enabled.

[jihuayu]

Hi @haanhvu, according to @git-hulk's suggestion, we can use @enjoy-binbin's solution. You can add a new command. Be bold in doing it, and feel free to continue raising questions here if any.

I think it’s better to keep the redis style MOVE key db. If we specifially need such a feature, we should add a new command, or at least do it in a way that is compatible with redis style.

[Chiro11]

@enjoy-binbin Add a new command looks good to me. I provide a compatible solution: When command args size is 3, MOVE key db , we treat it a dummy command. When command args size is 4, MOVE key ns_name ns_token ,we move it to new namespace.

This has not been implemented right? I'll work on this.

Are you still working on this?

[jihuayu]

Hi @Chiro11 It seems like nobody has work now. If you want to do it, you can send a PR directly.