Markus Elfring
Markus Elfring
I would like to point out that an identifier like “[`__VOLK_ASM`](https://github.com/gnuradio/volk/blob/a0e406e042ed9cda27333efa2de0fcc10912ea07/include/volk/volk_common.h#L12 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the compiler implementation.") to...
Would you like to add more error handling for return values from functions like the following? - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html) ⇒ [irecv_execute_script](https://github.com/libimobiledevice/libirecovery/blob/3687ea11271b79fb2643c8f041490544c17c5e58/src/libirecovery.c#L1397) - [ftell](http://pubs.opengroup.org/onlinepubs/9699919799/functions/ftell.html) ⇒ [buffer_read_from_filename](https://github.com/libimobiledevice/libirecovery/blob/22973c90b089a15b1682ebfefc5cbf1560219ef2/tools/irecovery.c#L91)
I would like to point out that an identifier like "[`_LIBARMADITO_SCAN_H_`](https://github.com/armadito/armadito-av/blob/4fdebaf7be3a8f6be1a30f7661c29315d2ce1255/core/libarmadito/include/libarmadito/scan.h#L43)" [does eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
Would you like to improve the documentation for the components of this software library?
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
I would like to point out that an identifier like “[`__raft_malloc`](https://github.com/willemt/raft/blob/b8ba76e1f8033ea92121e4eee4648ae57d2ceb2e/src/raft_server.c#L31 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler implementation.") to the...
Would you like to add more error handling for return values from functions like the following? - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [game_mode_initialise_gpu](https://github.com/FeralInteractive/gamemode/blob/be4eeea109dc6d98ce2b0c40ce6d1b0ee5b4720b/daemon/gamemode-gpu.c#L67) - [pthread_rwlock_init](https://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_rwlock_init.html "Initialize a read-write lock object.") ⇒...
Would you like to [wrap any pointers](https://github.com/BlindMindStudios/StarRuler2-Source/blob/dad50e1b02606c4b3c5c309e857dd5929df560db/source/game/obj/obj_group.cpp#L53 "Update candidate: ObjectGroup class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [HexGrid](https://github.com/BlindMindStudios/StarRuler2-Source/blob/dad50e1b02606c4b3c5c309e857dd5929df560db/source/game/util/hex_grid.h#L54 "Destructor for HexGrid") - [GLShaderProgram::reset](https://github.com/BlindMindStudios/StarRuler2-Source/blob/dad50e1b02606c4b3c5c309e857dd5929df560db/source/game/render/gl_shader.cpp#L130...
Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [Object::load](https://github.com/BlindMindStudios/StarRuler2-Source/blob/dad50e1b02606c4b3c5c309e857dd5929df560db/source/game/obj/object_saving.cpp#L122) - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html "Duplicate a string") ⇒ [FindFonts](https://github.com/BlindMindStudios/StarRuler2-Source/blob/dad50e1b02606c4b3c5c309e857dd5929df560db/source/freetype2/src/tools/ftrandom/ftrandom.c#L371)