Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
I've tried to rebase it, but I'm a bit unclear about the current Pulp 2 vs Pulp 3 status. I still see traces of Runcible, but isn't that Pulp 2-only?...
I'm not a fan of long term unstable code in a project. If nobody uses them and they're broken, we might as well remove the code. I'd be happy to...
I have no idea either :)
@jhoblitt any plans to revisit this?
I've submitted https://github.com/voxpupuli/puppet-jenkins/pull/957 as an alternative implementation which I believe is simpler.
This now needs a rebase. I've made some changes (https://github.com/voxpupuli/puppet-jenkins/commit/5fb0dee289343b9e32e5bcadd7c3ab11d9c751d7 and https://github.com/voxpupuli/puppet-jenkins/commit/db25b59fd2d4f5bd3b52998e781f72ff655d16c6) that at least allow you to work around this.
Closing for inactivity.
> A potential solution is to convert the [fact](https://github.com/voxpupuli/puppet-jenkins/blob/master/lib/puppet/jenkins/facts.rb#L27) from returning a string to an array, and then using `in` in the conditional. This is IMHO the correct solution.
https://github.com/voxpupuli/puppet-nginx/pull/1414 should probably be merged first.
Converting to draft since I'm using Travis instead of local tests. Feel free to point out errors or mistakes, but no need to approve until it's green.