Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
I agree. The method needs a `if not current_version` with the proper error message (`Failed to detect current version` or similar). Would you be willing to provide a patch?
Could you add that to the README? With that I think this should be ok to merge. Ideally it would also have a test.
I think you're right that this is an odd workflow. A patch would be welcome.
I consider this out of scope for this project. It's easy to automate yourself. Since we're using annotated tags, I personally use the `--follow-tags` option with git push and even...
Maybe you could use `--no-commit --tag` and maybe set the new version to match the current version and then call it with `--commit --no-tag`. It sounds to me like you'd...
I can't answer for @c4urself but I'm sure we'd accept a PR to handle something like. To play the devils advocate: Isn't ```v{current_version}``` specific enough for you?
Could you describe a bit more what this PR is intended to resolve? It'll be particularly interesting to see when this is ran. I was wondering whether this was pre...
> The only question i have is, Should the cleanups be happening as a part of db:seed or they are needed to be done as a part of db:migrate instead...
Looks like we'll need to raise the Rubocop target version to Ruby 2.7 for this.
This needs to be updated: https://github.com/theforeman/foreman/blob/f28bc34cc749886b80f8b0f909438118368c6040/bundler.d/test.rb#L24 But first we need to release a version that has 2.7 as the target, which is set in https://github.com/theforeman/theforeman-rubocop/blob/main/rules/ruby_target.yml.