Ewoud Kohl van Wijngaarden

Results 1159 comments of Ewoud Kohl van Wijngaarden

Note to self: * disable `Style/BracesAroundHashParameters` per https://github.com/voxpupuli/modulesync_config/commit/01141b273bab9f314cfcb66840f5365e31fd593c * Disallow empty string in `Nginx::Time` * replace `proxy_value` in spec tests with a real value

You're right: this is not something puppet can easily do. You can think of some workarounds, for example create a custom fact ```enable_ssl``` which looks at if a certificate has...

> As to your first suggestion: With a set-up that relies heavily – if not exclusively – on hiera and auto-lookup like ours, this would either require support for this...

> I haven't used Letsencrypt much, but I noticed that they also support using DNS records for validation, maybe that would be easier to setup (when new domains / subdomains...

I do agree we could include an optional class if it works. Edit: submitted too soon. I'm afraid I don't have time to properly work this out any time soon.

@law that's a good idea but shouldn't you add a before on the exec so you're sure it executes before nginx?

This has a merge conflict. Could you make sure it cleanly applies?

The current solution does work and there hasn't been activity for a year. Closing, but feel free to open a new PR.

> In both cases, the repo enabled by the `garethr/erlang` module has such an old version of Erlang, that the modern version of `rabbitmq-server` can't be used. Given garethr/erlang used...

I've rebased this and fixed it up in https://github.com/voxpupuli/puppet-jenkins/pull/1057. I did notice labels were missing, but I see you already removed your fork so I think you have no more...