Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
@bastelfreak I think acceptance tests are hard here because SRV records are hard without a real DNS server. I guess it'd be enough to verify that the server actually starts...
> WARNING: The following packages cannot be authenticated! > jenkins This looks to be the real reason. Something's wrong with the GPG signature.
Currently the acceptance tests are failing. I've tried to take a look at it, but haven't had a lot of time for it. This is probably related to the CLI...
https://github.com/voxpupuli/puppet-jenkins/pull/981 at least made the test suite green on Ubuntu in Travis. On a libvirt VM it was also green on CentOS for me. Can't quite explain why yet, but...
I've started to assign things to the 2.0.0 milestone.
Well, it looks like I should have checked more. Looks like I should create a 3.0.0 milestone instead.
> From the test failure, it looks like you'll need to rerecord the VCR for `test_create_remote_with_http_proxy_creds` in `yum_test.rb`. I'm not sure what changed, we'd have to rerecord the new VCR...
Given my current time constraints I think that would be best.
They already were failing. I haven't been able to pinpoint why. When I run the tests on a Vagrant VM (using libvirt) they pass but on Docker containers they fail.
Maybe. From a user perspective the max total sleep time is ignored and that's a change. Perhaps we should go further and actually remove the parameter from the types. That...