Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
I wonder if this explains the EL7 acceptance test failure in docker. Could you come up with a patch?
I opened https://github.com/voxpupuli/puppet-jenkins/pull/996 with your suggestion to see if it fixes the EL7 Docker install test.
I don't think this is the right place. This is only the Puppet module to install and configure the nginx package. That means you need to contact the nginx developers.
Ah, then I misunderstood. In that case, a PR is welcome.
I think https://github.com/voxpupuli/puppet-nginx/pull/1501 should fix the acceptance tests, except for EL7. But that shouldn't hold up this PR. Unit tests should suffice for that (but those are still running).
Closing for inactivity. Please open a new PR if you're still interested.
I added this to the milestone: https://github.com/voxpupuli/puppet-jenkins/milestone/12. What are your thoughts on finishing those issues before the release?
I'd prefer to look at it when https://github.com/voxpupuli/puppet-jenkins/pull/962 is merged. That's currently still running.
I merged #1003.
I need a new release, so I fixed the tests. Now I also want to get this in: * https://github.com/voxpupuli/puppet-jenkins/pull/1045 * https://github.com/voxpupuli/puppet-jenkins/pull/1055 * https://github.com/voxpupuli/puppet-jenkins/pull/1056