Ewoud Kohl van Wijngaarden

Results 1155 comments of Ewoud Kohl van Wijngaarden

> I think the easiest solution would be to call the binary `forklift` and the actions `pipeline-install` and `pipeline-upgrade`, then we just need to forget the dash in the future....

Currently obsah is rather tied to its own parser since the main function also does the processing. Right now I don't have the time to dive into how that would...

Rebased to at least resolve the merge conflicts. Depends on https://github.com/theforeman/obsah/pull/8.

Looking at the timing it really doesn't make a time difference for Python so I'm dropping it again.

It is good to update packages with yum repo files but we could change it to ```*release*``` so it also covers things like ```epel-release``` and others but gracefully skip ```foreman-release-scl```...

It probably means providing the right options according to https://www.vagrantup.com/docs/provisioning/docker.html similar to https://github.com/theforeman/forklift/blob/0e5c47900233684d97ee0fd8152ba40f1640880c/vagrant/lib/forklift/box_distributor.rb#L211-L243

We don't set this in boxes. It's part of core vagrant and thus documented there: https://www.vagrantup.com/docs/providers/basic_usage.html#default-provider

@dLobatog it sounds like we need some reverse proxy middleware. The ```app/controllers/unattended_controller.rb``` has some manual code but a proper implementation would use ```X-Forwarded-Host``` and ```X-Forwarded-Port``` too I guess.

@san7ket it was moved in https://github.com/theforeman/foreman/commit/4093de10f0f54c8c943e7df8c173f7fb66e2ef0e @dLobatog it appears the correct rails way is http://api.rubyonrails.org/classes/ActionDispatch/RemoteIp.html but I don't think it sets the ```SERVER_NAME``` and ```SERVER_PORT```. We should use that in...

You could have a look at [luna-devel](https://github.com/theforeman/forklift/blob/master/playbooks/luna-devel.yml). which you can base yourself on.