Ewoud Kohl van Wijngaarden
Ewoud Kohl van Wijngaarden
This needs some work. This was passing on Ruby 3.1 but it fails on Ruby 2.7. Setting back to draft.
At least this passes RuboCop now without an update. Let's see if the other tests are also green. Please review carefully.
All green. Please review again.
> however on `3.0.4` I'm not able to run rails, startup is failing with following error: Yes, #9230 is needed for that. While the tests don't pass, you can use...
Rebased since some preparation work was merged. No real change compared to the previous version. My plan is to submit the gem updates after branching, which would give us a...
If you look through the history of https://github.com/fog/fog-core/commits/master/lib/fog/core/ssh.rb it makes me think that https://github.com/fog/fog-core/commit/9640a4a40580191ddb92287f03f9b27864fc7f21 is fully compatible with the current API. That was part of fog-core 2.2.1 which we have...
We did have fog-google which pinned fog-core to 2.1.0. According to https://github.com/theforeman/foreman/commit/14e90094305a29440923a8fc21af1afde3173314 fog-core 2.1.0 couldn't use a newer version of net-ssh. I believe it was that.
We're in branching now. Should we first get RC1 out and then aim this for RC2?
https://github.com/theforeman/foreman-packaging/pull/8380 is the packaging side of the gem itself.
This feels like a really trivial PR and there really isn't another way to do this. Is it really needed to sign a whole license agreement?