puppet-jenkins icon indicating copy to clipboard operation
puppet-jenkins copied to clipboard

download jenkins-cli.jar instead of extracting it from jenkins.war

Open hoomaan-kh opened this issue 4 years ago • 5 comments

… the Jenkins-cli.

https://github.com/voxpupuli/puppet-jenkins/issues/998

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

hoomaan-kh avatar Jan 27 '21 04:01 hoomaan-kh

This has a merge conflict. Could you make sure it cleanly applies?

ekohl avatar Jan 28 '21 17:01 ekohl

The conflict had been fixed

hoomaan-kh avatar Jan 28 '21 22:01 hoomaan-kh

For reference, the docs for this are here: https://www.jenkins.io/doc/book/managing/cli/#downloading-the-client

kenyon avatar Jan 29 '21 07:01 kenyon

Do we need more changes or it could be merged?

hoomaan-kh avatar Jul 18 '21 10:07 hoomaan-kh

Do we need more changes or it could be merged?

We need the tests to pass. I rebased on latest master and squashed the commits.

kenyon avatar Aug 03 '21 06:08 kenyon

The current solution does work and there hasn't been activity for a year. Closing, but feel free to open a new PR.

ekohl avatar Sep 16 '22 18:09 ekohl