Dylan Thacker-Smith

This should probably also work in warn mode, since it parses strictly then falls back to lax mode only if it can't be strictly parsed. So I guess warn mode...

Yes, it is a bug, but we need to consider any existing liquid code that could break from fixing it. The strict parser ended up acting like another version of...

Seems like it is an upstream bug fix which is desirable to inherit in liquid. I'm not aware of it causing problems with Shopify upgrading ruby, so it doesn't seem...

Actually, ruby 2.7 is only supported for security maintenance upstream. It looks like we could instead just remove that `result = result.to_i if n == 0` line once ruby 2.7...

The reasoning was provided in the pull request that introduced the render tag (https://github.com/Shopify/liquid/pull/1122) > Unlike `include`, `render` does not permit specifying the target > template using a variable, only...

> What we will do if things go like this? I need to show flags according to user input, there are literally hundreds of them. Writing hundreds of if-else statements...

> Found this workaround. By appending a string (even empty) it transforms the variable into a string. That is clearly relying on a bug. Intentionally relying on a bug is...

> I just had this issue when trying to dynamically render a snippet, but instead of Shopify showing a liquid error like it usually does it just broke the whole...

Looks like it has worked that way since the first git commit to this repo (https://github.com/Shopify/liquid/commit/1d647361e1a39ee09f1bd2d62701925c0128c578) and it doesn't really seem intentional. It seems like the validation is mostly there...

Oh, I wasn't aware that filters had been receiving this special `Liquid::Expression::MethodLiteral` object, given the `to_liquid` implementation on that class returning an empty string. As in, it wasn't actually a...