Dylan Thacker-Smith
Dylan Thacker-Smith
Based on https://github.com/Shopify/liquid-c/pull/123, it looks like we actually have themes that depend on this liquid quirk. We might want to consider just supporting that syntax. It isn't actually that unreasonable....
Was the behaviour consistent between liquid and liquid-c? > Ranges with floats get converted to ranges of integers (e.g. `1.1..5.5` gets converted to range `1..5`) I don't think that is...
We need to make it easier to test the impact of possibly breaking changes on existing templates, since that is what is blocking changes like this from happening. This is...
We should try implementing this in liquid-c, since performance was the main concern with #170. #170 also seems to have implemented support for `\` escaping, but I don't know if...
This is missing integration tests, which are preferred since they get used with liquid-c.
I'm onboard with changing the default `Liquid::Drop#to_s` method to support overriding `to_str`. However, I would avoid the respond_to check by doing this ```diff - def to_s + def to_str self.class.name...
What happened to Travis CI? It doesn't seem to be running anymore
So essentially this would be like gofmt auto formatting their liquid to have standard spacing in tags. It is an opinionated approach, but I think it would be fine. >...
ya, I understand. That is what I meant by losing the original intent of the code.
> I agree that it makes more sense like this. But this fix is not strictly backwards compatible... We could log a warning when a `for` tag is used with...