Dylan Thacker-Smith
Dylan Thacker-Smith
The main use case for the gem is to get all the committed changes in the after_commit callback, however, changes to the record in the after_commit callbacks affect `transaction_changed_attributes`. For...
cc @Shopify/component-patterns ## Problem We have tended to avoid using promises throughout out codebase and have instead relied on preloading associations. However, as we split our codebase into components that...
@ko1 this is the patch for bug: https://bugs.ruby-lang.org/issues/14607 I think it would be easier to review the patch with additional context of the rest of the `rb_profile_frames` function, where I...
Fixes #318 @centny does this fix the problem for you?
## Problem I noticed that there were 11 open "Upgrade V8 binaries" PRs which had been automatically opened and had been sitting for over a month. ## Solution Reduce the...
Looks like there were a couple of notable changes that didn't have a corresponding changelog entry.
## Problem https://github.com/rogchap/v8go/pull/266 is attempting to add a constructor function for a V8 string, but we don't yet have a v8go.String type for it to return. It is also adding...
Extracted from PR comment https://github.com/rogchap/v8go/pull/195/files#r782269530, where the PR was adding functions to allow exceptions to be created. While reviewing that PR, I realized that we should make it easier to...
We should consider following the [Google C++ Style Guide](https://google.github.io/styleguide/cppguide.html) which would make the code more consistent with V8 which this project heavily uses. Under the [Namespaces section](https://google.github.io/styleguide/cppguide.html#Namespaces) it says >...
v8go.cc is calling malloc in a few places (as can be seen by the following grep command) but not checking for a NULL return value to handle an out of...