Dylan Thacker-Smith
Dylan Thacker-Smith
Just to be clear, I'm not against adding a changelog. Also, perhaps we should bump to `1.0.0` in the future to indicate that we do use version numbers to indicate...
I tried to reproduce the issue with the following script ```ruby require 'graphql/batch' class EchoLoader < GraphQL::Batch::Loader def perform(keys) keys.each { |key| fulfill(key, key) } end end class IntegerWrapperType <...
Yes, that code example tracks the start and end of resolving a field, not the time it spends actually executing those fields, so no other integration is needed with graphql-ruby....
> am hoping there's some prior art from others I can learn from Sorry, this isn't something that much to us since we use [IdentityCache](https://github.com/shopify/identity_cache) to cache whole rows, so...
Another option would be to use [GraphQL::Execution::Lookahead](https://graphql-ruby.org/api-doc/1.8.13/GraphQL/Execution/Lookahead#looking-ahead-in-a-field) to figure out what subfields are requested to have it influence the query. I think the simplest way to handle this would be...
The documentation is lacking in the project, it mostly just has overview documentation in the form of a README, but could use reference documentation. Outside of a GraphQL context, `GraphQL::Batch.batch`...
The loader itself doesn't give enough to reproduce this problem, especially when there is already a test that covers a basic use case. Could you try to provide a minimal...
graphql-batch is database independent. Query multiplexing happens in the same thread, so it shouldn't cause new thread-safety issues. If it doesn't just work, then try to isolate the issue to...
If you just want to do some unbatched query then promises allows you to do that as mentioned in https://github.com/lgierth/promise.rb/issues/23#issuecomment-276437726 I haven't prototyped concurrent executor in graphql-batch yet. Previously I...
> However, I'm not sure what the long game is here? Sorry, I should open a PR on shopify that shows the bigger picture. Basically, this is just a primitive...