Dylan Thacker-Smith
Dylan Thacker-Smith
> ### Behavior of unhandled Procs > Cases when `Proc` are not handled sometimes lead to exceptions, but other times they could lead to exposure of internal code structure Where...
> Ideally I think it would be better to allow passing the `context` to drops in `Drop#invoke_drop(method_or_key, context)`, and get rid of `context=`. Would that assign the context every time...
> Is `context=` only useful for drops? Liquid seems to use duck typing for interactions with Liquid::Drop, rather than checks like `.is_a?(Liquid::Drop)`. I'm not sure if this flexibility is actually...
> A thread local is appealing but a basic implementation would preclude Liquid's use within concurrent applications that don't use a thread-per-connection model. I'm not sure I understand what this...
> A possible future for minimizing latency could involve returning futures from drops, and allowing concurrent execution of the template. If we want to go down this path, then I...
> I'd like to propose a new mandatory argument to the well known `to_liquid` which would be the `@context` (`obj.to_liquid(@context)`). I couldn't find a clear reason why these 2 operations...
Actually, `Liquid::Utils.to_liquid(value, context)` could be shortened to `context.to_liquid(value)`
One of the primary reasons why having `.to_liquid(context)` and initializing drops with the context appeals to me is that it avoids having these values in an invalid state. We could...
Perhaps if the added strictness deprecation warnings are too disruptive, then we could initially make that opt-in by using something like `require "liquid/next"` and have `require "liquid"` preserve the current...
The problem is that `foo=="bar"` gets parsed as a single [Liquid::QuotedFragment](https://github.com/Shopify/liquid/blob/fc1c0d0d83835f2c8629a0a166959c263778ceb6/lib/liquid.rb#L35) in [Liquid::If::Syntax](https://github.com/Shopify/liquid/blob/fc1c0d0d83835f2c8629a0a166959c263778ceb6/lib/liquid/tags/if.rb#L13) as if it were `'foo=="bar"'` due to liquid's lax expression parsing. It will behave as expected with...