Dylan Thacker-Smith
Dylan Thacker-Smith
Please add a regression test for #749 and the issue I pointed out in https://github.com/Shopify/liquid/pull/750#discussion_r60956416, so we can try to fix this properly this time.
> should_use_cache? checks for any open transaction which is joinable This is only meant to exclude the transaction that wraps tests to rollback the test state. Ideally, Active Record would...
IDC will cache the absence of a record, so this could just be a cache inconsistency, which is an expected occurrence when cache invalidations fails. I think we failed to...
Also, we would ideally have a way to opt-out of `nil` caching (as discussed in #501)
You could start tcp server on a different port to mock out memcached and connect to that rather than connecting to the actual memcached. That server can just respond to...
I'm no longer even using node.js, so am unlikely to pick this up.
By default, do you mean you are using a [Hash `default_proc`](https://ruby-doc.org/core-3.0.0/Hash.html#class-Hash-label-Default+Proc)? We are relying on the `key?` method to tell us if the variable is assigned, since the `[]` method...
You mean you have something `{{ my_var | default: "Some Value" }}` where `my_var` hasn't been assigned? If that is the case, then the error happens before getting to the...
I'm not sure what activity was expected, there are no merge conflicts to rebase to fix and I didn't receive any feedback on the pull request to address.