David Luzar

Results 833 comments of David Luzar

> I like the idea of this. From classroom experience, I suggest making this optional. Eg the toasts might become distracting when a couple dozen students have connected to the...

prereq: https://github.com/excalidraw/excalidraw/pull/6092

fixed via https://github.com/excalidraw/excalidraw/pull/6104/files

Some notes: - I'm supporting any HTML attributes on the welcomeScreen menu items as there's not reason not to. This way the host app can pass any ARIA or data...

> Also as discussed yesterday lets folllow kebab case for folder so `welcomeScreen` - >`welcome-screen` Oh, forgot to add to PR todos — wanted to do last for better reviewing...

No, nothing currently in the works with respect to animations. But @dai-shi has made an app to take your excalidraw drawings and animate it as a whole: https://dai-shi.github.io/excalidraw-animate/ (https://github.com/dai-shi/excalidraw-animate)

Hi. What is this PR attempting to solve?

Hi. Works for me. Can you reproduce consistently and provide steps?

From the images above it _may_ be that the canvas size exceeded the database limit of 1MB. For some stupid reason we're not showing an error message on these failures...

@nikolra right, so size seems to be the issue indeed, as to the total sits just below 1MB. EDIT: actually, the Scene size (shapes on canvas) only says `2 bytes`....