David Luzar

Results 833 comments of David Luzar

hey @zsviczian — sorry, I was not keeping an eye at this PR and a few others (and same applies to @ad1992) because we were deep in other things and...

Apart from the GPL 3.0 license, we should decide whether to make this fully baked in, or fully host-implemented. Right now the implementation is attempting to be host-implemented, but at...

We should actually not be showing that shortcut in the help dialog on Firefox as it won't work — it's missing the async clipboard API support for this.

> @dwelle Is there no way to make it work? Isn't there [`clipboard.setImageData()`](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/clipboard/setImageData) (edit: it appears that is for web extensions)? correct, that's just for browser extensions. > @dwelle Could...

lol, not checking what I'm pasting 😅 https://excalidraw-git-dwelle-hide-png-copy-help-dialog-excalidraw.vercel.app/

Fair point. ![image](https://user-images.githubusercontent.com/5153846/212772121-e0e3a30f-3db6-4492-addd-e50840ca8f5f.png)

> Probably 👇🏻 can be removed from the docs ? If we want we can still keep the below image in GitHub readme but in main docs I guess its...

> > You mean nesting this into @excalidraw/excalidraw? > > Yes I'm thinking the top-level structure should look like this: - Introduction - Editor - `@excalidraw/excalidraw` - ... (other packages...

We should be building docs (CI) only when there's any change in `docs/`.

> > We should be building docs (CI) only when there's any change in `docs/`. > > That's what happens now, isnt' it? Nvm. I swear I'd seen it building...