David Luzar

Results 833 comments of David Luzar

- [x] z-index fix for ![image](https://user-images.githubusercontent.com/5153846/209957521-a3ab95ac-deab-45f9-aee1-6ecb633276fe.png)

- [x] instead of having default menu items as subcomponents of `Menu.Item`, let's add them as subcomponents of `Menu`. So `Menu.ItemLoadScene`, `Menu.ItemSaveToActiveFile` etc, as originally suggested. The reason being that...

ad [`6ea25b8` (#6034)](https://github.com/excalidraw/excalidraw/pull/6034/commits/6ea25b8ad155bced06015d4aba3c31fd123f7bc4) I think hiding the stats when mobile menu open isn't the right solution. On larger screens (still in mobile view) it's distracting. Especially once we redesign the...

> I still think we should have some keyword to make it more intuitive that these are existing items so how about `Menu.DefaultItem.LoadScene` or just `ExcalidrawMenu.LoadScene` The idea should be...

- [ ] Library dropdown menu regressed because it's now using `` component that's designed for `` only: ![image](https://user-images.githubusercontent.com/5153846/210067818-3964cb83-1d21-452d-8c5b-8ab222d3d7f5.png)

> Also in this case it would be better to introduce a `Menu.List` since now button will be rendered by host so all menu items will now go into menu...

Removed the `main-menu-footer` wrapper (https://github.com/excalidraw/excalidraw/pull/6034/commits/75524d5f2b201b32c3a421faaf682a0fc2a3d9f4) as the default items should work without it. It was also using the excalidraw-app stylesheet. And we should come up with generic item wrappers (see...

@chrisyelf no, this will allow exporting with a fixed size, but not drawing / scrolling outside of the frame(s).

Yeah, stabilization is not a bad idea!

I guess let's do it the "customize everything" for now? 1. if `` not rendered from host app, default to something like this: ![image](https://user-images.githubusercontent.com/5153846/208889540-5eb7e8b5-1b13-4a58-bf1e-a229a7e3ce55.png) 2. if `` rendered from host...