David Luzar

Results 833 comments of David Luzar

@maielo few days... ![image](https://user-images.githubusercontent.com/5153846/213305863-ccf645c7-c6eb-417a-bc92-784205a55729.png)

Hi @proke03, thanks for the PR. We should still prompt for confirmation regardless of how the clear canvas is invoked. This will require a bit of refactor that I did...

- simplified the state handling [`52f52e1` (#6114)](https://github.com/excalidraw/excalidraw/pull/6114/commits/52f52e14d4f9793e4283e6d9fd853998d012c3d5) - fixed using platform agnostic keys (cmd/ctrl) - switched from `keyup` to `keydown` since that's what we use for most of our shortcuts....

Notes on the updated API. - The sidebar trigger is now a `` instead of ``, because now you should be rendering it outside of the sidebar as it's not...

> Shouldn;t name of `` be `` to align in with rest ? (i know it's outside, but namespace wise it should be same IMHO) I'm afraid `` will make...

### API for sidebar headers When rendering multiple tabs, you may want to have a different sidebar header for each tab. For example, a sidebar that contains `library` and `comments`...

I'm also thinking of nuking the "render default header if no custom one supplied". Will remove tons of complexity. In other components we don't do that either, and make you...

> What kind of tabs are you talking about inside Sidebar ? Is it the normal tabs for switching layout ? > In that case we can have separate tabs...

closed via https://github.com/excalidraw/excalidraw/pull/5663 and https://github.com/excalidraw/excalidraw/pull/6213

@zsviczian @ad1992 @pomdtr this PR is not ready, but you can take a look at the `exportToCanvas` API (config mainly) [src/scene/export.ts](https://github.com/excalidraw/excalidraw/pull/6086/files#diff-91b6e2243746c6661270480d9d05856a54d6af764eabe54f1f2df33f082b7b47), whether it makes sense to you or you're missing...