Dawid Weiss

Results 161 comments of Dawid Weiss

> > > Thanks @gokaai -- I'll try to review soon! > > > If possible please try not to force-push: it removes the history of the past commits and...

I'm closing it. I don't think we can reproduce the original issue so let's not worry about it.

Just wanted to mention one more path leading to the problem (an attempt to resolve a configuration at configuration-time): ``` Caused by: org.gradle.api.GradleException: You need to add a repository containing...

I do have a small repro, although I'm no longer sure - maybe it's palantir plugin's fault... The problem seems to surface only when there is a lazy task dependency...

@ngallagher I think it'd be convenient to make StreamProvider public and accepting a factory in its constructor. Then you can pass a preconfigured factory (disabling entity resolution) and use it...

I created a fork and implemented the changes I mentioned above since simple-xml makes so many people so nervous because of CVEs. https://github.com/dweiss/simplexml The "default" Provider configuration disables entity expansion...

I will take a look tomorrow - was out of office last week.

> The latter should result in warnings but not in hard errors. I think it should result in hard errors, always. If you know the use is justified, you'll have...