Dawid Weiss

Results 161 comments of Dawid Weiss

So, in other words - the POMs have to be right. If enabling metadata means we have odd entries in POMs, I'm -1 for adding metadata. The lucene-root dependency may...

I didn't want to discourage you from trying - maybe the solution is simple, somewhere. I just recall spending a few hours trying to figure out how to make the...

Just a note from the side (I'm not familiar with this code): somehow I don't believe switching to a soft reference here is solving anything - it just shoves the...

No worries - just tweak whatever you want. I just didn't want jenkins to complain over and over.

I'm not a big fan of the manifest-based solution, even if I initially wrote it. If you use the module path, starting demos is fairly simple - see here: https://github.com/apache/lucene/blob/main/dev-tools/scripts/smokeTestRelease.py#L661-L665...

I think some of these "demo" classes come from different modules - this is legacy and highly unstructured... But feel free to provide a patch, sure. I was thinking about...

I've moved this class to buildSrc so that it's precompiled before the scripts and removed the Cloneable interface.

I would leave -Xlint:exports entirely out of the patch - this is not easily fixable; the module API is broken in that it exposes types that are not public but...

> Yeah, those are actually API bugs? They do look like API issues to me. Useful warning, by the way.