Dawid Weiss

Results 161 comments of Dawid Weiss

Having the same file with different content on branches won't work for cherry picking commits (backporting), unfortunately.

> > I'm not sure why my gradle leaks daemons like a sieve. > > Hahaha. 🤓🐰 This is probably because you're using different vms or gradle options (jvm options)....

> We can also discuss this in the other issue. I am still starring at the code and don't get how it works with decrementing. What's the difference between aquires...

Ok, I think I get it - the state counts acquire/release permits in both the upper and the lower part of state variable; the distinction is made to differentiate the...

Amazingly, ChatGPT also got the gist of it. Wild. https://chatgpt.com/c/689edb07-79c8-8326-bfe2-6e9b28f5a452

The code seems correct to me (and I ran a simple test to verify). It's more likely that the reference to a RefCountedArena object itself is lost somewhere. This can...

I'm in awe. I asked chatgpt to recreate what I have written in the past and it did a flawless job, actually. Wow. Anyway. https://github.com/apache/lucene/pull/15077 has what I had in...

The tests seem to pass with the ref counting trick for me. Maybe Mike's repro will fail though - something worth trying.

Oh, sorry. I checked this on main, not 9x. Maybe it'll help to diagnose the issue on 9x though!

Wouldn't an empty marker interface be easier to work with? Anyway, such changes should probably be motivated by something else, otherwise they lack the necessary context for saying if it's...