Dawid Weiss

Results 161 comments of Dawid Weiss

I don't use hamcrest but I'll take a look at what I can do. No need to pull in another library just for one test.

I think it's best explained by looking at the code, David. It's really tiny. Take a look at the tests and then dig into the class that retrieves offsets from...

I will split the original issue into two - one adjusting Matches API slightly and the other with highlighter components on top of that API; I'll provide some more high-level...

It's SOLR-14889. I think it may automatically merge (because those lines are identical) but it's hard to tell in advance. Just wanted you to know Chris is working on some...

I think it's just much shorter invocation in the end - when you look at the diff you'll see it. I also don't know if the checksum format is required...

I second this wholeheartedly. It really helps to keep things consistent because you can reuse the same npm for multiple needs. A workaround would be to allow a lazy setup...

Sorry, I wasn't clear - I know npm path can be set at configuration time. I don't think it can be set afterward, at execution time. This is the difference...

Really? Well, even if then you could just add a task dependency in between to set the exe path - you get the gist. I didn't think about using buildsrc...

Let that echoCp task accept a command line argument (project property or proper command-line argument[1]) that is the file name to write the classpath to - no surprises then. [1]...

> This weird lucene-root dependency is only here; it isn't in any of the other Lucene modules. I confirmed this only appears here because of the use of this Gradle...