Dawid Weiss

The other build did succeed after a retry - ``` Error in 'PUT https://repository.apache.org/content/repositories/snapshots/org/apache/lucene/lucene-backward-codecs/maven-metadata.xml.sha256'. Waiting 1000ms before next retry, 2 retries left Successfully ran 'PUT https://repository.apache.org/content/repositories/snapshots/org/apache/lucene/lucene-backward-codecs/maven-metadata.xml.sha256' after 1 retries ```

I've added ```-Dorg.gradle.internal.network.retry.initial.backOff=5000 -Dorg.gradle.internal.network.retry.max.attempts=20``` to these configurations on Jenkins. Let's see if this helps.

I also let infra know: https://issues.apache.org/jira/browse/INFRA-26821

You can also use a JDK that has jmod files in place. Azul's distributions do, for example. There is plenty to choose from: https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions

I toyed a bit with debugging this and there's a difference in how these line comments appear to JavaCommentsHelper.wrapLineComments. With JDK21, it receives that comment line-by-line. With JDK23, it receives...

For what it's worth, core tests pass when I do this: ``` diff --git a/core/src/main/java/com/google/googlejavaformat/java/JavaCommentsHelper.java b/core/src/main/java/com/google/googlejavaformat/java/JavaCommentsHelper.java index d34ecc4..d54b231 100644 --- a/core/src/main/java/com/google/googlejavaformat/java/JavaCommentsHelper.java +++ b/core/src/main/java/com/google/googlejavaformat/java/JavaCommentsHelper.java @@ -49,7 +49,11 @@ public final class...

I think you're right - that's a spot-on observation. Interestingly, this comment appears inline with the code, not as a javadoc of anything in particular [1]. Could be a regression...

Thank you for adding the regression test. I've created a PR with the basic workaround I suggested, hope it helps.

Perhaps this wasn't clear - the important bit here is the use of TermInSetQuery (the query parsed substitutes large boolean expressions to this type of query to prevent max-boolean-clauses-exceeded errors).

I think this comment provides an explanation of what is happening: https://github.com/gradle/gradle/issues/23585#issuecomment-1403862031