lucene icon indicating copy to clipboard operation
lucene copied to clipboard

Throw CorruptSegmentInfoException on encountering missing segment info (_N.si) file in CheckIndex

Open gokaai opened this issue 1 year ago • 9 comments

Description

Changes:

  • Throw CorruptSegmentInfoException on encountering missing segment info (_N.si) file in CheckIndex. This is a step towards enabling #7820

gokaai avatar Dec 03 '23 12:12 gokaai

Decided to tackle this in smaller steps -

  • Made a new (simpler) revision where we throw a more specific error on encountering missing segment info. Created a new exception CorruptSegmentInfoException.java
  • Will create a new commit (or issue?) to add in fixes and unit tests for exorciseIndex

gokaai avatar Dec 19 '23 16:12 gokaai

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Jan 18 '24 00:01 github-actions[bot]

I edited the PR description to more accurately represent what is being done. We aren't dealing with the exorcism issue yet, but throwing the right exception on encountering missing segment info. I will tackle the final step (actually making exorcism possible) in a subsequent PR

gokaai avatar Jan 19 '24 14:01 gokaai

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Feb 04 '24 00:02 github-actions[bot]

Thanks @gokaai -- I'll try to review soon!

If possible please try not to force-push: it removes the history of the past commits and makes it harder to see what changed on this iteration :)

mikemccand avatar Feb 05 '24 18:02 mikemccand

Thanks @gokaai -- I'll try to review soon!

If possible please try not to force-push: it removes the history of the past commits and makes it harder to see what changed on this iteration :)

Sorry about that @mikemccand . I messed up my workspace and couldn't salvage it - I'll keep it in mind while making any new revisions.

gokaai avatar Feb 08 '24 09:02 gokaai

Thanks @gokaai -- I'll try to review soon! If possible please try not to force-push: it removes the history of the past commits and makes it harder to see what changed on this iteration :)

Sorry about th

Ahh OK no worries. I experience such git disasters myself far more often than I would hope :)

mikemccand avatar Feb 08 '24 11:02 mikemccand

Thanks @gokaai -- I'll try to review soon! If possible please try not to force-push: it removes the history of the past commits and makes it harder to see what changed on this iteration :)

Sorry about th

Ahh OK no worries. I experience such git disasters myself far more often than I would hope :)

Look at what git reflog does and how it may help. It is really, really difficult to not be able to recover your work with git.

dweiss avatar Feb 08 '24 19:02 dweiss

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution!

github-actions[bot] avatar Feb 23 '24 00:02 github-actions[bot]