David Snopek

Results 410 comments of David Snopek
trafficstars

Just a couple links to some of the earlier discussion about how to integrate this extension: - https://github.com/GodotVR/godot_openxr_vendors/issues/224 - https://github.com/GodotVR/godot_openxr_vendors/issues/133

Superseded by https://github.com/GodotVR/godot_openxr_vendors/pull/273

> We might want to backport at least this change to 4.2 / 4.1 It's tagged for cherry-picking! It'll get pulled in when I do the next round

This should be fixed now (by PR https://github.com/godotengine/godot-cpp/pull/1504)

I intend to cherry-pick https://github.com/godotengine/godot-cpp/pull/1504, so a separate PR just for this change isn't necessary **UPDATE:** Er, well, I wasn't planning to cherry-pick to 4.0, so if we want this...

Here's the next 4.2 cherry-picking PR (which includes this changes via PR #1504): https://github.com/godotengine/godot-cpp/pull/1527

And here's the 4.1 cherry-pick: https://github.com/godotengine/godot-cpp/pull/1529 So, at this point, maybe this PR could be reworked to bring this change to the `4.0` branch, since I don't intend to cherry-pick...

I suspect the CI builds are stuck because we didn't cherry-pick PR https://github.com/godotengine/godot-cpp/pull/1496 to 4.0. I just added the `cherrypick:4.0` label there

PR https://github.com/godotengine/godot-cpp/pull/1533 does the few cherry-picks we have for 4.0. Let's see if that manages to finish CI!

Rebasing this on the latest `4.0` branch will probably get the CI passing, now that PR https://github.com/godotengine/godot-cpp/pull/1533 is merged