David Snopek

Results 413 comments of David Snopek
trafficstars

> I'm not seeing how I can register compatibility methods for `GDVIRTUAL` functions, is that implementer? There is no way to safely change a virtual method in a binary compatible...

Actually, looking at the PR in more detail, I'm not sure changing `const`-ness actually breaks compatibility. It may be fine. Someone should test if a GDExtension that overrides this virtual...

Which specific deprecated function is godot-cpp using? I agree that we should update to use the latest GDExtension interface functions, but I don't know that we can "require" that we...

I just posted PR https://github.com/godotengine/godot-cpp/pull/1792 which should allow godot-cpp to work with latest Godot `master` compiled with `scons deprecated=no`

Yep, it's on my TODO list! > Use `deprecated=no` build godot will has this problem, because `gdextension_classdb_construct_object` be marked deprecated. If you're keeping up with Godot `master` and using `deprecated=no`,...

> What I'm worried about is that this discourages binding and extension maintainers from investing into long-term projects. > > While it's an easy cop-out for us in the GDExtension...

Discussed at the GDExtension meeting and we discussed a number of ideas: - To soften the message we could say that we "reserve the right to break compatibility" to fix...

Superseded by https://github.com/godotengine/godot-cpp/pull/1755

Thanks! It'd probably be good to add a check like you show above, but you shouldn't be directly calling `ClassDB::add_virtual_method()` anyway. Instead, use the `GDVIRTUAL*()` and `GDVIRTUAL_BIND()` macros. They'll take...