David Smiley

Thanks for contributing during the CoC hackathon! You have the honors of the first PR contribution :-)

Just a quick comment: next time please don't rebase a PR; simply merge main into it. I've found rebasing PRs to be a bad practice as it resets the GitHub...

I don't recall Crave being confused by a merge from "main". I do recall once in a while (rare-ish), GitHub PR would show changes from the merge that it shouldn't.

I think you may find Spatial4J not well suited to that kind of customization. Good luck.

Changes seem fine. I see a test failure: org.apache.solr.client.solrj.impl.CloudSolrClientRoutingTest#routeParamHandling ```java.lang.NullPointerException: Cannot invoke "org.apache.solr.common.util.NamedList.get(String)" because the return value of "org.apache.solr.common.util.NamedList.get(String)" is null 2> at org.apache.solr.handler.component.DebugComponent.handleResponses(DebugComponent.java:196) 2> java.lang.NullPointerException: Cannot invoke "org.apache.solr.common.util.NamedList.get(String)" because...

Just a quick thought -- it may be helpful to go back to the commit that added this (I remember; it was Jason and I was looking at it), and...

A question for you: in your mind, are code reviews strictly either "drive by" or "collaborative"? Is there something else? Can they be a bit of both? Is "drive by"...

Great; thanks

> spotless and tidy are added to run on build files too Awesome!

I checked out this branch and did `gw assemble` then renamed `solr/packaging/build/solr-10.0.0-SNAPSHOT/` to have an "-after" suffix. Then I checked out a recent main (before cross-DC addition) and did `gw...