David Smiley
David Smiley
Thanks Christos. I suggest a separate PR for the version bumping listed. It'd also be nice to backport that to 9x. May I suggest that we have a separate PR...
BTW if you are worried about how to update this PR if those other things merge; I could figure that out. The end-state will be no different, so it should...
I think the next step is just some dependency version alignment?
If the root cause is what it says it is (seems very plausible to me!), then why isn't this PR nothing more than simply moving this line _with it's preceding...
I looked at this for 15min just now. This may help a little but I'm not optimistic; obviously is just a bandaid and test anti-pattern -- what I tell new...
A better compromise without more sleeps on the happy path would be to execute the test that follows this call with `org.apache.solr.common.util.RetryUtil`. That, I'd get behind.
I would have preferred a solution that doesn't involve a special case explicitly for s390x. Like being able to opt-out of docker tests (for whatever reason).
In Lucene, we're not always good at steering users to preferred functionality, away from old/legacy functionality, nor are we good about removing such old/legacy functionality. IMO this is true of...
Sounds good to me. I'd like to raise this (and the original Highlighter) in the dev list first to get broad input before making a big decision of this nature.
Makes sense. Thanks for being willing to consider improving the UnifiedHighlighter for considering boosts. RE your point #2 -- until you benchmark -- hard to say. I'm skeptical the FVH...