apache
SOLR-15349: Remove solrcore.properties support
https://issues.apache.org/jira/browse/SOLR-15349
Description
According to the JIRA, solrcore.properties has been deprecated, though in looking closer, it appears that mentioning has been hidden/removed, but the code is still there.
Solution
I have removed the solrcore.properties support from CoreDescriptor. In the process, I see that we still support the concept of a custom properties file for a core, and loading that. Therefore I updated the unit test to exercise that code path.
I am thinking that we should rename TestSolrCoreProperties.java to TestCustomCoreProperties.java as we no longer have a solrcore.properties concept.
Now, if the whole properties for a Core concept is no longer relevant, I'd be happy to remove the whole thing!
I will backport to 9x a deprecation on CoreDescriptor. If 10 releases before this gets sorted, then I guess this will be a 11x feature.
Tests
Updated unit test
@dsmiley before I move forward on this (and maybe @janhoy you have an opinoin), the PR as is keeps the custom properties being loaded in for a core... I want to make sure that is a "good thing" ;-)
Since solrcore.properties is deprecated, but core "properties" file support hasn't, I'm going to move forward with just this removal to get in under the solr 10 deadline.
