David Smiley

Results 391 comments of David Smiley

(no CHANGES.txt; just deprecating low level stuff & refactoring stuff that shouldn't have an effect) WDYT @cpoerschke

> Therefore it could be nice to "Other Changes" mention about the deprecation before it goes away in Solr 10 or so. The @deprecated annotation serves the same purpose but...

Planned Git commit message: > QueryResult refactoring so that it's only returned from SolrIndexSearcher instead of being provided to it. Deprecated APIs in 9x; should be removed later. Deprecated old...

oh the irony; a CHANGES.txt conflict; sigh

Addressing your nit on renaming `_request` to `request` wasn't fully possible for various reasons at first, so I started pulling on that thread, doing some refactoring that ultimately led to...

Want to quickly respond to this: > a Lucene contribution to create a new query No! The Lucene project is not the only place where subclasses of Query classes exist...

I did the work of migrating to a QParser but don't have permissions to push to your PR branch. Beware, I'm reverting most/all of the files that you modified of...

@cpoerschke see the parent JIRA issue for the real state of this controvertial PR

FYI I'm *very* eager to examine this in detail but am on vacation this week.

Let's get #3214 merged first, thus narrowing this PR to just what it needs to do.