David Smiley
David Smiley
> But if SMO is backed by a LinkedHashMap, wouldn't then these changes become obsolete? What is the point of unmarshalling to SMO (backed by a LinkedHashMap) instead of a...
Map.get, Map.remove, Map.put -- basic operations are O(1) in a hash based Map, but not in a dense array List that SOM is today.
> So what is the point of changing from a LinkedHashMap to LinkedHashMap in a SMO? A LinkedHashMap doesn't implement NamedList. An SMO does. Thus a Solr 10 server could...
I merged with main and tweaked the naming a little as I asked. But most notably, made the setting `false` by default, thus is an opt-in compatibility mechanism that can...
Looks good! But why not also do `_getStr` ? > https://issues.apache.org/jira/browse/SOLR-NavigableRemoveDeafult That URL is invalid
Obviously some formatting issues (you didn't run Tidy before committing) but looks good
I back-ported to branch_9x as well, and included the former method signatures with Deprecated annotations for backwards-compatibility. Thanks for contributing Gaurav!
Please stop force-pushing to PRs -- it resets the review state in GitHub. Any way, I will merge this soon; thank you!
@iamsanjay is anything stopping this from getting merged? Tests still pass? Need a CHANGES.txt saying something like: "Most remaining usages of Apache HttpClient in Solr switched to Jetty HttpClient (HTTP...
I'm looking forward to this getting in eventually!