David Smiley
David Smiley
Probably just a one-liner left and I'll merge away :-)
_Commenting to avoid auto-close_
I commented in JIRA about my interest in furthering this. I'm sure there are some nice-to-have's (score function access, documentation), but simply working code & tested is enough to merge....
Updating the PR to main was easy. Note that there is another PR #3340 that will overlap with this one which makes it possible for a DocTransformer to access the...
The ability to reference scores in a custom ValueSource based on DoubleValuesSource won't work with sorting. I filed this PR https://github.com/apache/lucene/pull/14654 to Lucene to trivially fix that issue. But since...
@hossman as the original author, maybe you'd like to review this?
I cherry-picked the Lucene 9.12.2 upgrade (thanks @HoustonPutman ), removed the `Ignore` annotation from the 2 tests, fixed a minor test bug that one Ignored test was hiding, and confirmed...
@AndreyBozhko you might be a good reviewer here
> making sure functions can access scores in distributed queries, What would go wrong if this functionality were used in such? An aside: I have a wish for our tests...
DocList / DocIterator / DocIterationInfo != a Lucene Scorable (which is an abstract class, BTW; limits creative class hierarchy possibilities). Furthermore the former is an iterator but the latter returns...