solr icon indicating copy to clipboard operation
solr copied to clipboard

Solr navigable remove default

Open wildtusker opened this issue 6 months ago • 2 comments

https://issues.apache.org/jira/browse/SOLR-NavigableRemoveDeafult

Description

_get(T t1,T t2) is replaced _get(T t1) in Navigable Object.All the classes which make call to this method get replaced

Solution

Analyze and Refactor feature of IntelliJ Idea were used to carry out the task

Tests

No tests developed.Tests Passed.

wildtusker avatar Jun 19 '25 14:06 wildtusker

Looks good! But why not also do _getStr ?

https://issues.apache.org/jira/browse/SOLR-NavigableRemoveDeafult

That URL is invalid

dsmiley avatar Jun 19 '25 14:06 dsmiley

Obviously some formatting issues (you didn't run Tidy before committing) but looks good

dsmiley avatar Jun 21 '25 15:06 dsmiley

I back-ported to branch_9x as well, and included the former method signatures with Deprecated annotations for backwards-compatibility.

Thanks for contributing Gaurav!

dsmiley avatar Jun 26 '25 03:06 dsmiley