Dimitrios Siganos

Results 54 comments of Dimitrios Siganos

Setting map_size in nano::mdb_env::init to 16 * 1024 * 1024, solves the problem.

@jamescoxon, if I remember well, you got this to work, didn't you?

I believe we check for final votes in places where we do not have a nano::vote object and we simply have a timestamp only. In that case, a nano::vote member...

Does this mean that confirmed elections will not remain in the AEC for some minutes after confirmation?

Example use case: Set a password for a wallet with `wallet_password_set` Lock a wallet (using the password set above) with `wallet_lock` Unlock a wallet with `wallet_unlock` Check if a wallet...

It makes sense to me but @clemahieu is a better person to review since he has plans for these classes.

I haven't looked at this closely but I agree with the idea that doing our own slicing of the string and parsing it ourselves is safer in short and medium...

I find the use of regex in this case over the top and a slight complication. It would be extremely easy to perform the same check with pure C/C++.

@RickiNano , @nano2dev you could write a specification for the allowed incoming string to be converted. For example, what is the max number, what is the smallest number, etc. so...

Guys, I still do not see parsing rules. Where are the rules? What's allowed, what is not? The rules need to answer all the questions I had posted at an...