Dimitrios Siganos

Results 54 comments of Dimitrios Siganos

I suggest you start with the packet `nano::keepalive`. It is a simple message. It contains a message header (which already has a to_string method) and an array of 8 ip...

Abandoning this Pr because we do not need QT6. We were upgrading to Qt6 because we thought Qt6 was necessary to work on Apple M1. However, the following appears to...

I imagine the problem here is that it is creating too many node objects and it is running out of resources. We should be able to rewrite this test to...

This is the code that handles the RPC: ``` void nano::json_handler::accounts_representatives () { boost::property_tree::ptree representatives; for (auto & accounts : request.get_child ("accounts")) { auto account (account_impl (accounts.second.data ())); auto transaction...

Yeap, just as I thought. If `ec` is set then `response_l` is ignored and `response_error` is returned instead. ``` void nano::json_handler::response_errors () { if (!ec && response_l.empty ()) { //...

Looking at the code for RPC `accounts_balances`, I would expect that it has the same problem: ``` void nano::json_handler::accounts_balances () { boost::property_tree::ptree balances; for (auto & accounts : request.get_child ("accounts"))...

`accounts_representatives` and `accounts_frontiers` likely have the same problem too.

1. I do not think we should treat the special case of all accounts being unopened differently because we are unnecessarily increasing complexity of coding and documentation. We would have...

Yes, that makes sense to me. It is simple, consistent and there is no loss of information.

I think the reverse_link table should be outside of the core database and in a separate auxiliary database. That will: * avoid the core database versioning problem * allow flexibility...