Dimitrios Siganos

The code changes look good to me except that previously the list of representatives was sorted whereas after this change it will not be sorted anymore. The documentation does not...

To clarify, I am saying let's not change the response to representatives option. Let's create a new option called `votes` which will return votes and their attributes.

This seems like a very simple unit test. We should try to debug it.

Sorry @zach, you are right on both counts. I am happy to close this ticket or change in any form you like.

We also have command `password_valid`, which seems to do a very similar thing.

If this ticket is primarily due to my feedback, I would like to emphasize that I am not advocating restructuring of existing documentation. I have not read most of the...

In general, you do want to have if statements checking if you are in testNet mode. You want to pass an object with context with any changing values and just...

This is the function that contains the assert statement: ``` int nano::rocksdb::store::clear (::rocksdb::ColumnFamilyHandle * column_family) { // Dropping completely removes the column auto name = column_family->GetName (); auto status =...

Thank you for doing this. We will look into merging this after the upcoming release because now it would be too risky to merge.

He had it as third party and I asked him to rename it to submodules because it seemed more correct. Not all submodules are third party.