Dimitrios Siganos

is_bootstrap_connection() does not do what it says

2

The function is_bootstrap_connection does not do what it says. It implies that it simply checks if a connection is bootstrap or not but, in fact, it does a lot more...

RPC accounts_receivable applies count restriction before sorting

1

RPC accounts_pending applies count before sorting. If both count and sorting are set, then it should get all results, sort them and then apply count. The documentation also needs to...

Unit test network.peer_max_tcp_attempts failing with TSAN enabled every time

1

``` ds@tux:~/nano/releases/V23.3$ make run_tsan_tests cd tsan && TSAN_OPTIONS="suppressions=../nano-node/tsan_suppressions" ./core_test --gtest_filter=network.peer_max_tcp_attempts Running main() from core_test_main.cc Note: Google Test filter = network.peer_max_tcp_attempts [==========] Running 1 test from 1 test suite. [----------] Global...

Tidy up of wallet locking and password RPC commands

2

Tidy up of wallet locking and password RPC commands. The following should be done: * password_valid: deprecated in favor of existing wallet_locked (which implies there is a valid password existing...

The accounts balances RPC returns possibly unconfined data. It should be changed to return only confirmed data by default, by use of include_only_confirmed option. Like the RPC account_balance does.

``` [ RUN ] bootstrap_processor.lazy_pruning_missing_block Assertion (election != nullptr) failed void nano::blocks_confirm(nano::node &, const std::vector &, const bool) /Users/runner/work/nano-node/nano-node/nano/test_common/system.cpp:258 0# nano::generate_stacktrace() in /Users/runner/work/nano-node/nano-node/build/./core_test 1# assert_internal(char const*, char const*, char const*,...

``` [ RUN ] rpc.wallet_info /Users/runner/work/nano-node/nano-node/nano/rpc_test/rpc.cpp:3401: Failure Expected equality of these values: "3" cemented_block_count_text Which is: "4" [ FAILED ] rpc.wallet_info (1433 ms) ``` https://github.com/nanocurrency/nano-node/runs/6028534288?check_suite_focus=true#step:6:2071

In github CI, the results of RPC, QT and load tests are not checked

2

### Summary In github CI, the results of RPC, QT and load tests are not checked. ### Node version V22.1 ### Build details manual ### OS and version any ###...

Optimistic elections are not working

2

Optimistic elections are not working since at least the introduction of the election scheduler. We need to review the approach we want to take w.r.t. optimistic elections. One reason (but...

``` [ RUN ] election.quorum_minimum_update_weight_before_quorum_checks /workspace/nano/core_test/election.cpp:246: Failure Value of: system.poll () Actual: Deadline expired Expected: [ FAILED ] election.quorum_minimum_update_weight_before_quorum_checks (15386 ms) ``` https://github.com/nanocurrency/nano-node/runs/5752564359?check_suite_focus=true#step:5:552