Dave MacFarlane comments

Results 249 comments of


                                            Dave MacFarlane

[API] subprojects and subproject endpoints

Changes requested 1. Add an expository paragraph or 2 to explain what the API user is getting when they access the endpoint, so they know why they would want to...

[tools] Implement LorisInstance in tools directory

the critical ones were fixed, but there's still some other ones that need to be fixed according to @CamilleBeau.. @CamilleBeau can you give a list of which are outstanding?

Add the ability to use PSCID in place of CandID in the candidates API.

@xlecours Can you help me update the swagger schema and review? I looked into `modules/api/static/schema-v0.0.4-dev.yml ` to try but it's not clear to me how to update it there..

Add the ability to use PSCID in place of CandID in the candidates API.

It would break scripts that assume it's the case on v0.0.3 on instances where it's not the case.

Add the ability to use PSCID in place of CandID in the candidates API.

But maybe it would be reasonable to release it as v0.0.4 and remove `-dev`?

Add the ability to use PSCID in place of CandID in the candidates API.

I incorporated the changes from the v0.0.4-dev into the 0.0.3 schema and then copied it back on top of the `schema-v0.0.4-dev.yml` file because 1. it more accurately represents what the...

Add the ability to use PSCID in place of CandID in the candidates API.

@xlecours @ridz1208 added a note.. is this good to be merged now?

Add the ability to use PSCID in place of CandID in the candidates API.

Good enough for me!

[candidate_profile] Access denied not properly shown to the user.

What do you mean "doesn't have the permission to access the `candidate_profile` module"?

[candidate_list] Remove meaningless Latest_Visit_Status column

Not sure if this should target v24 or be kept in draft mode until after the release since we've already tested it with the meaningless behaviour.