Dave MacFarlane

Results 249 comments of Dave MacFarlane

I think since MRI violations is the last module in https://github.com/aces/Loris/projects/8 I might as well just do it and then delete that code in this PR.

Blocked by the release.. not critical, I just noticed an old ticket that seemed easy to tackle. I just changed the main type hint and fixed the errors flagged by...

@kongtiaowang can you review/test this?

@suzanne-lee were the bugs resolved for the next testing round?

@satvik-tha-god The build should be fixed now. Can you rebase this to make sure tests still pass?

Can you elabourate? How is it not accurate anymore?

@ridz1208 is going to split this up into multiple PRs. Parts of it (the NDB_BVL_Instrument part) are critical, parts of it (the survey part) can go into a bug fix...

I haven't looked at them in depth, but maybe the `php/libraries` changes should be moved out to a different PR? They seem useful on their own and only need to...