Dave MacFarlane

Results 249 comments of Dave MacFarlane

It comes from the t0002-gitfile.sh test, which is explicitly testing against invalid .git directories.. so it seems the test is working.

UnidiffApply execs the system patch command, so it's likely that those are legitimate OS specific failures.

It might be worth looking into. Diffing isn't hard to do, any reasonable diff algorithm can be written in Go. It's patching that gets difficult, because you need to support...

dgit uses ape/patch and ape/diff on Plan 9. It's defined here: https://github.com/driusan/dgit/blob/master/git/consts_plan9.go

But using git as a manager for patches is a very git way of doing things, just not the GitHub way. The whole `git am` and `git format-patch` commands are...

Thanks, it might take me a bit to review since it's a fairly big refactoring (for the size of the project at least). If you're in a hurry and there's...

Re: 2. You're right, disregard. It's not showing up as a rename in the GitHub diff because the added test makes it dissimilar enough for git to not consider it...

Sorry about the delay. I think the main things holding this up are: 1. The unnecessary pulling in of a lot of non-stdlib dependencies for the tests, when a simple...

Thanks.. that looks like dead code, but I think it might actually be why the MRI Violations tests are failing, since MRI Violations hasn't been converted to React yet. Gonna...