Dave MacFarlane comments

Results 249 comments of


                                            Dave MacFarlane

Incorrect error message with invalid date format

Fixed by #8279

[data_release] Cannot filter by Unversioned files

I'm testing this module for the 25 release and can't reproduce. I can't sort by the Version column (creating another ticket), but filtering is working as expected.

[Core] Allow parallel handling of requests from same session

Note: Talked to @cmadjar before skipping the tests and we agreed to rely on manual testing the mri violations module for now, because of the significant performance implications for other...

Think of a better name...?

phpc? (I'm not very good at naming either.)

RFC: Stay VM/JIT, or abandon and go only AOT?

IMO the value of having a JIT mode is lowered by the fact that PHP ~7~ 8 will have a jit mode with the "real" php implementation anyways. On the...

function calls in `compile {}` blocks only accept variables as arguments

I'm not sure that having the restriction prevents that, though, since the blocks can still reference things from the outer scope. ie. the macros happily generates code if you do:...

function calls in `compile {}` blocks only accept variables as arguments

It didn't at https://github.com/ircmaxell/php-compiler/pull/60/commits/9116d508ac83e45bec7bc947d90c53893e36e5b9#diff-95e58c95e9cfcc3dc033dc60409d0f94R39, but I guess that might just mean we don't have a test testing the PHP memory allocator.

function calls in `compile {}` blocks only accept variables as arguments

Should we close this now that it at least throws an error, or do you still want to document the reason for the restriction?

Resolve all files in a project during AOT compilation (Composer integration)

I'm not sure that this is possible in all cases. how can you exhaustively know what files autoloaders might touch if someone does: ```php // please don't do this. $x...

Resolve all files in a project during AOT compilation (Composer integration)

I agree that just pessimistically assuming anything might be included and using dead code elimination to get rid of the things that aren't is the way to go, but what...