Dave Protasowski

Results 151 issues of Dave Protasowski

It seems like `TestControllerHA` in regular e2e is flakey - I wonder if it's because we haven't bumped this constant and potentailly other ones in the e2e scripts https://github.com/knative/serving/blob/a0a1ac776600486a21b7714a33be84d8be18884e/test/ha/ha.go#L40 _Originally...

See: https://prow.knative.dev/job-history/gs/knative-prow/pr-logs/directory/certmanager-integration-tests_serving_main > ha.go:92: WaitForNewLeaders[controller] still see intersection: map[controller-68c4cdccdb-tg7v6:{}] > controller_test.go:73: Failed to find new leader: context deadline exceeded > prober.go:187: Stopping all probers /assign @skonto

We should move this e2e test to net-contour - given it's specific to only that integration _Originally posted by @dprotaso in https://github.com/knative/serving/issues/15188#issuecomment-2122899540_

Probably we need to revise that because protoc-gen-gogo has been deprecated long ago (see https://github.com/gogo/protobuf). _Originally posted by @skonto in https://github.com/knative/serving/issues/15101#issuecomment-2114785855_

triage/accepted

When we merged the domain mapping webhook in https://github.com/knative/serving/pull/14082 older installations leave resources around. The release notes didn't specify how clean up the resources. In theory we could create a...

Part of https://github.com/knative/serving/issues/14640 /assign @ReToCode @skonto

approved
size/XS

**What type of PR is this?** /kind gep /area conformance **What this PR does / why we need it**: This promotes backend protocol selection as part of Gateway v1.2 release...

approved
size/S
release-note
cncf-cla: yes
kind/gep
area/conformance

The scheme match via pseudo headers suggested in https://github.com/kubernetes-sigs/gateway-api/issues/2455 only applies to HTTP/2. It would be useful to still match on the scheme for _any_ HTTP version. One use case...

lifecycle/rotten

failed run is here ``` {Failed === RUN TestChangeDefaultDomain logger.go:146: 2024-06-27T20:55:21.619Z DEBUG config-store configmap/store.go:155 namespace config "config-network" config was added or updated: &config.Config{DefaultIngressClass:"istio.ingress.networking.knative.dev", DomainTemplate:"{{.Name}}.{{.Namespace}}.{{.Domain}}", TagTemplate:"{{.Tag}}-{{.Name}}", AutoTLS:false, ExternalDomainTLS:false, HTTPProtocol:"enabled", DefaultCertificateClass:"cert-manager.certificate.networking.knative.dev", NamespaceWildcardCertSelector:(*v1.LabelSelector)(0xc000392a20),...

- Fix external domain tls tests - bad substitution - fix env var parsing

size/XS
approved