serving icon indicating copy to clipboard operation
serving copied to clipboard

certmanager-integration-tests_serving_main is running wrong tests

Open dprotaso opened this issue 1 year ago • 4 comments

See: https://prow.knative.dev/job-history/gs/knative-prow/pr-logs/directory/certmanager-integration-tests_serving_main

ha.go:92: WaitForNewLeaders[controller] still see intersection: map[controller-68c4cdccdb-tg7v6:{}] controller_test.go:73: Failed to find new leader: context deadline exceeded prober.go:187: Stopping all probers

/assign @skonto

dprotaso avatar May 23 '24 01:05 dprotaso

It seems like TestControllerHA in regular e2e is flakey - I wonder if it's because we haven't bumped this constant and potentailly other ones in the e2e scripts

https://github.com/knative/serving/blob/a0a1ac776600486a21b7714a33be84d8be18884e/test/ha/ha.go#L40

dprotaso avatar May 23 '24 02:05 dprotaso

It also seems like the cert manager test is actually running the regular e2e test and not the cert manager one

in this run we see it running externaldomain tests

https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative_serving/15235/certmanager-integration-tests_serving_main/1793408871688048640

dprotaso avatar May 23 '24 02:05 dprotaso

I'll disable the test until this is sorted

dprotaso avatar May 23 '24 02:05 dprotaso

I'm going to split out the TestControllerHA flake

dprotaso avatar May 23 '24 14:05 dprotaso