gateway-api icon indicating copy to clipboard operation
gateway-api copied to clipboard

promote HTTPRoute backend protocol from experimental to extended

Open dprotaso opened this issue 1 year ago • 7 comments

What type of PR is this? /kind gep /area conformance

What this PR does / why we need it: This promotes backend protocol selection as part of Gateway v1.2 release

Which issue(s) this PR fixes: Part of https://github.com/kubernetes-sigs/gateway-api/issues/1911

Does this PR introduce a user-facing change?:

Backend Protocol Selection is no longer experimental and is now part of HTTPRoute Extended Conformance

dprotaso avatar May 22 '24 17:05 dprotaso

Is there any website documentation we need to update for this as well?

Aside from that, lgtm, I'll approve.

/approve

youngnick avatar May 24 '24 05:05 youngnick

Sorry yeah - I need to drop this notice on this page https://gateway-api.sigs.k8s.io/guides/backend-protocol/

Screenshot 2024-05-24 at 10 35 06 AM

dprotaso avatar May 24 '24 14:05 dprotaso

done

dprotaso avatar May 24 '24 14:05 dprotaso

Thanks @dprotaso! This LGTM, but I think we need to have some kind of solution for https://github.com/kubernetes-sigs/gateway-api/issues/3115 before we accept docs updates for unreleased changes. I don't really have a great solution yet, but open to ideas.

robscott avatar May 24 '24 18:05 robscott

Oh I didn't realize you don't have branches for the docs - should I rollback the docs change?

dprotaso avatar May 24 '24 18:05 dprotaso

Oh I didn't realize you don't have branches for the docs - should I rollback the docs change?

Yeah unfortunately that's probably the best for now, but I really don't want to miss changing docs in the future. Hoping someone can help us figure out a better approach to docs versioning to make this less painful in the future.

robscott avatar May 24 '24 19:05 robscott

Pulled the docs changes into a separate PR - https://github.com/kubernetes-sigs/gateway-api/pull/3120

dprotaso avatar May 30 '24 16:05 dprotaso

I pulled out the docs changes into a separate PR. This change is ready to be merged.

dprotaso avatar May 30 '24 16:05 dprotaso

weird verify took 2h

/retest

dprotaso avatar May 30 '24 18:05 dprotaso

Thanks @dprotaso!

/lgtm /approve

robscott avatar Jun 03 '24 18:06 robscott

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, robscott, youngnick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [robscott,youngnick]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 03 '24 18:06 k8s-ci-robot