serving
serving copied to clipboard
knative
[flaky] pkg/reconciler/nscert: TestChangeDefaultDomain
failed run is here
{Failed === RUN TestChangeDefaultDomain
logger.go:146: 2024-06-27T20:55:21.619Z DEBUG config-store configmap/store.go:155 namespace config "config-network" config was added or updated: &config.Config{DefaultIngressClass:"istio.ingress.networking.knative.dev", DomainTemplate:"{{.Name}}.{{.Namespace}}.{{.Domain}}", TagTemplate:"{{.Tag}}-{{.Name}}", AutoTLS:false, ExternalDomainTLS:false, HTTPProtocol:"enabled", DefaultCertificateClass:"cert-manager.certificate.networking.knative.dev", NamespaceWildcardCertSelector:(*v1.LabelSelector)(0xc000392a20), RolloutDurationSecs:0, AutocreateClusterDomainClaims:false, EnableMeshPodAddressability:false, MeshCompatibilityMode:"auto", DefaultExternalScheme:"http", InternalEncryption:false, SystemInternalTLS:"disabled", ClusterLocalDomainTLS:"disabled"}
logger.go:146: 2024-06-27T20:55:21.620Z DEBUG config-store configmap/store.go:155 namespace config "config-domain" config was added or updated: &config.Domain{Domains:map[string]config.DomainConfig{"svc.cluster.local":config.DomainConfig{Selector:(*config.LabelSelector)(0xc00038f858), Type:"wildcard"}}}
logger.go:146: 2024-06-27T20:55:21.620Z DEBUG config-store configmap/store.go:155 namespace config "config-network" config was added or updated: &config.Config{DefaultIngressClass:"istio.ingress.networking.knative.dev", DomainTemplate:"{{.Name}}.{{.Namespace}}.{{.Domain}}", TagTemplate:"{{.Tag}}-{{.Name}}", AutoTLS:true, ExternalDomainTLS:true, HTTPProtocol:"enabled", DefaultCertificateClass:"cert-manager.certificate.networking.knative.dev", NamespaceWildcardCertSelector:(*v1.LabelSelector)(0xc000392b40), RolloutDurationSecs:0, AutocreateClusterDomainClaims:false, EnableMeshPodAddressability:false, MeshCompatibilityMode:"auto", DefaultExternalScheme:"http", InternalEncryption:false, SystemInternalTLS:"disabled", ClusterLocalDomainTLS:"disabled"}
logger.go:146: 2024-06-27T20:55:21.621Z INFO controller/controller.go:484 Starting controller and workers {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
logger.go:146: 2024-06-27T20:55:21.621Z INFO controller/controller.go:494 Started workers {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
logger.go:146: 2024-06-27T20:55:21.621Z DEBUG controller/controller.go:418 Adding to queue testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "/testns"}
logger.go:146: 2024-06-27T20:55:21.622Z DEBUG controller/controller.go:511 Processing from queue testns (depth: 0) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
logger.go:146: 2024-06-27T20:55:21.622Z INFO controller/controller.go:548 Reconcile succeeded {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "8cfb2d18-09f1-4af4-b550-dc103d46191b", "knative.dev/key": "testns", "duration": "535.82µs"}
logger.go:146: 2024-06-27T20:55:21.628Z DEBUG config-store configmap/store.go:155 namespace config "config-domain" config was added or updated: &config.Domain{Domains:map[string]config.DomainConfig{"example.net":config.DomainConfig{Selector:(*config.LabelSelector)(0xc000180070), Type:"wildcard"}}}
logger.go:146: 2024-06-27T20:55:21.636Z DEBUG controller/controller.go:287 Adding to the slow queue testns (depth(total/slow): 2/1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "/testns"}
logger.go:146: 2024-06-27T20:55:21.628Z DEBUG controller/controller.go:418 Adding to queue testns/testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "testns/testns"}
logger.go:146: 2024-06-27T20:55:21.637Z DEBUG controller/controller.go:511 Processing from queue testns/testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
logger.go:146: 2024-06-27T20:55:21.638Z DEBUG controller/controller.go:418 Adding to queue testns/testns (depth: 2) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "testns/testns"}
nscert_test.go:458: Expected 1 certificate, got 2.
logger.go:146: 2024-06-27T20:55:21.639Z INFO controller/controller.go:496 Shutting down workers {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
logger.go:146: 2024-06-27T20:55:21.655Z INFO controller/controller.go:548 Reconcile succeeded {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "808ff485-e38f-4ffe-a8a9-b71823976e8b", "knative.dev/key": "testns/testns", "duration": "17.529427ms"}
logger.go:146: 2024-06-27T20:55:21.655Z DEBUG controller/controller.go:511 Processing from queue testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
logger.go:146: 2024-06-27T20:55:21.656Z ERROR namespace/reconciler.go:294 Returned an error {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "051776ac-23e4-4481-bc01-0b67845e18de", "knative.dev/key": "testns", "targetMethod": "ReconcileKind", "error": "certificates.networking.internal.knative.dev \"testns.svc.cluster.local\" not found"}
logger.go:146: 2024-06-27T20:55:21.656Z ERROR controller/controller.go:564 Reconcile error {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "051776ac-23e4-4481-bc01-0b67845e18de", "knative.dev/key": "testns", "duration": "665.46µs", "error": "certificates.networking.internal.knative.dev \"testns.svc.cluster.local\" not found"}
logger.go:146: 2024-06-27T20:55:21.656Z DEBUG controller/controller.go:511 Processing from queue testns/testns (depth: 0) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
logger.go:146: 2024-06-27T20:55:21.656Z ERROR namespace/reconciler.go:294 Returned an error {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "be8f0972-004e-4b11-8439-fbd58d6babb2", "knative.dev/key": "testns/testns", "targetMethod": "ReconcileKind", "error": "certificates.networking.internal.knative.dev \"testns.svc.cluster.local\" not found"}
logger.go:146: 2024-06-27T20:55:21.657Z ERROR controller/controller.go:564 Reconcile error {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "be8f0972-004e-4b11-8439-fbd58d6babb2", "knative.dev/key": "testns/testns", "duration": "494.02µs", "error": "certificates.networking.internal.knative.dev \"testns.svc.cluster.local\" not found"}
--- FAIL: TestChangeDefaultDomain (0.27s)
}
@dprotaso I tried to reproduce the error by running the tests but can't get it to fail. Is there a specific condition or environment in which it fails.
=== RUN TestChangeDefaultDomain
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.266+0530 DEBUG config-store configmap/store.go:155 namespace config "config-network" config was added or updated: &config.Config{DefaultIngressClass:"istio.ingress.networking.knative.dev", DomainTemplate:"{{.Name}}.{{.Namespace}}.{{.Domain}}", TagTemplate:"{{.Tag}}-{{.Name}}", AutoTLS:false, ExternalDomainTLS:false, HTTPProtocol:"enabled", DefaultCertificateClass:"cert-manager.certificate.networking.knative.dev", NamespaceWildcardCertSelector:(*v1.LabelSelector)(0xc000697080), RolloutDurationSecs:0, AutocreateClusterDomainClaims:false, EnableMeshPodAddressability:false, MeshCompatibilityMode:"auto", DefaultExternalScheme:"http", InternalEncryption:false, SystemInternalTLS:"disabled", ClusterLocalDomainTLS:"disabled"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.266+0530 DEBUG config-store configmap/store.go:155 namespace config "config-domain" config was added or updated: &config.Domain{Domains:map[string]config.DomainConfig{"svc.cluster.local":config.DomainConfig{Selector:(*config.LabelSelector)(0xc0003a3968), Type:"wildcard"}}}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.266+0530 DEBUG config-store configmap/store.go:155 namespace config "config-network" config was added or updated: &config.Config{DefaultIngressClass:"istio.ingress.networking.knative.dev", DomainTemplate:"{{.Name}}.{{.Namespace}}.{{.Domain}}", TagTemplate:"{{.Tag}}-{{.Name}}", AutoTLS:true, ExternalDomainTLS:true, HTTPProtocol:"enabled", DefaultCertificateClass:"cert-manager.certificate.networking.knative.dev", NamespaceWildcardCertSelector:(*v1.LabelSelector)(0xc000697200), RolloutDurationSecs:0, AutocreateClusterDomainClaims:false, EnableMeshPodAddressability:false, MeshCompatibilityMode:"auto", DefaultExternalScheme:"http", InternalEncryption:false, SystemInternalTLS:"disabled", ClusterLocalDomainTLS:"disabled"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.266+0530 INFO controller/controller.go:484 Starting controller and workers {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.267+0530 DEBUG controller/controller.go:418 Adding to queue testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "/testns"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.267+0530 INFO controller/controller.go:494 Started workers {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.267+0530 DEBUG controller/controller.go:511 Processing from queue testns (depth: 0) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.267+0530 INFO controller/controller.go:548 Reconcile succeeded {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "2af358ff-f5da-472a-9723-94109b88dd53", "knative.dev/key": "testns", "duration": "351.401µs"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.267+0530 DEBUG controller/controller.go:418 Adding to queue testns/testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "testns/testns"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 DEBUG config-store configmap/store.go:155 namespace config "config-domain" config was added or updated: &config.Domain{Domains:map[string]config.DomainConfig{"example.net":config.DomainConfig{Selector:(*config.LabelSelector)(0xc000124298), Type:"wildcard"}}}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 DEBUG controller/controller.go:511 Processing from queue testns/testns (depth: 0) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 DEBUG controller/controller.go:287 Adding to the slow queue testns (depth(total/slow): 1/1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "/testns"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 INFO controller/controller.go:548 Reconcile succeeded {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "f39bd950-949b-4417-bad1-cf2886caed36", "knative.dev/key": "testns/testns", "duration": "181.887µs"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 DEBUG controller/controller.go:511 Processing from queue testns (depth: 0) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 INFO controller/controller.go:548 Reconcile succeeded {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "9e0daf2d-a2c6-4d4c-828b-ef4cad860106", "knative.dev/key": "testns", "duration": "98.118µs"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 DEBUG controller/controller.go:418 Adding to queue testns/testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "testns/testns"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 INFO controller/controller.go:496 Shutting down workers {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 DEBUG controller/controller.go:418 Adding to queue testns/testns (depth: 1) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/key": "testns/testns"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.268+0530 DEBUG controller/controller.go:511 Processing from queue testns/testns (depth: 0) {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace"}
/home/tejas/Desktop/serving/pkg/reconciler/nscert/logger.go:146: 2024-07-04T23:27:14.269+0530 INFO controller/controller.go:548 Reconcile succeeded {"knative.dev/controller": "knative.dev.serving.pkg.reconciler.nscert.reconciler", "knative.dev/kind": "core.Namespace", "knative.dev/traceid": "85f62f7a-1417-48be-b339-af7856a58c55", "knative.dev/key": "testns/testns", "duration": "121.213µs"}
--- PASS: TestChangeDefaultDomain (0.11s)
PASS
ok knative.dev/serving/pkg/reconciler/nscert (cached)
It's flaky so it doesn't happen all the time. You can try to run the test many times (-count 1000) to see if you get a repro case.
Sorry, I was solving another issue. Yeah, I literally ran it a thousand times but it seemed to pass everytime