serving icon indicating copy to clipboard operation
serving copied to clipboard

Fix external domain tls tests

Open dprotaso opened this issue 1 year ago • 4 comments

  • Fix external domain tls tests - bad substitution
  • fix env var parsing

dprotaso avatar Jun 28 '24 18:06 dprotaso

/test all

dprotaso avatar Jun 28 '24 18:06 dprotaso

/test https

dprotaso avatar Jun 28 '24 18:06 dprotaso

@dprotaso: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
https_serving_main fd154494897d1f92a846e2d804f9e0c5229d377d link false /test https

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

knative-prow[bot] avatar Jun 28 '24 20:06 knative-prow[bot]

/assign @ReToCode

This doesn't fix the tests but fixes the setup

dprotaso avatar Jul 03 '24 15:07 dprotaso

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [ReToCode,dprotaso]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

knative-prow[bot] avatar Jul 04 '24 05:07 knative-prow[bot]